[webkit-reviews] review granted: [Bug 79366] [BlackBerry] InputHandler requires cleanup of Navigation Mode handling. : [Attachment 128480] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Mike Fenton <mifenton at rim.com>'s
request for review:
Bug 79366: [BlackBerry] InputHandler requires cleanup of Navigation Mode
handling.
https://bugs.webkit.org/show_bug.cgi?id=79366

Attachment 128480: Patch
https://bugs.webkit.org/attachment.cgi?id=128480&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128480&action=review


Looks good, BlackBerry:: prefix cleanup can be done later.

>> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:406
>> +	   
m_webPage->m_inputHandler->handleKeyboardInput(BlackBerry::Platform::KeyboardEv
ent(character, BlackBerry::Platform::KeyboardEvent::KeyDown, KEYMOD_SHIFT));
> 
> Maybe you dont need BlackBerry prefix.

Maybe you dont need BlackBerry prefix.