[webkit-reviews] review granted: [Bug 78602] [Qt] Page doesn't get repainted while panning is in progress : [Attachment 128465] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 06:05:22 PST 2012


Simon Hausmann <hausmann at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 78602: [Qt] Page doesn't get repainted while panning is in progress
https://bugs.webkit.org/show_bug.cgi?id=78602

Attachment 128465: Patch
https://bugs.webkit.org/attachment.cgi?id=128465&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128465&action=review


>>> Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp:434
>>> +void LayerTreeHostQt::setVisibleContentRectTrajectoryVector(const IntRect&
rect, const FloatPoint& trajectoryVector)
>> 
>> Just thinking, should it be called setVisibleContentRectAndTrajectoryVector?

> 
> I didn't want to do the renaming, but I would suggest that we go for
> 
> LayerTreeHostQt::setVisibleContentRectForPanning(const FloatPoint&
trajectoryVector)
> LayerTreeHostQt::setVisibleContentRectForScaling(const IntRect& rect, float
scale)

_Those_ sounds like nice and descriptive names :)


More information about the webkit-reviews mailing list