[webkit-reviews] review granted: [Bug 79318] [BlackBerry] Anchor mailto: with target set won't launch Messaging application when clicked : [Attachment 128397] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 79318: [BlackBerry] Anchor mailto: with target set won't launch Messaging
application when clicked
https://bugs.webkit.org/show_bug.cgi?id=79318

Attachment 128397: Patch
https://bugs.webkit.org/attachment.cgi?id=128397&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128397&action=review


Looks good.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:282
> +    BlackBerry::Platform::NetworkRequest platformRequest;

Can probably remove the BlackBerry prefix.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:285
> +	   platformRequest,
BlackBerry::Platform::NavigationType(action.type()))) {

Ditto.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:287
> +	       || action.type() == NavigationTypeFormResubmitted)

Can be just one line.