[webkit-reviews] review granted: [Bug 79196] [BlackBerry] Upstream GLES2Context.{h, cpp} : [Attachment 128436] Patch v3

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 79196: [BlackBerry] Upstream GLES2Context.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79196

Attachment 128436: Patch v3
https://bugs.webkit.org/attachment.cgi?id=128436&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128436&action=review


LGTM.

> Source/WebKit/blackberry/ChangeLog:1
> +2012-02-22  Leo Yang  <leo.yang at torchmobile.com.cn>

It is 23 feb now.

> Source/WebKit/blackberry/WebKitSupport/GLES2Context.cpp:60
> +    if (surface)

Can just do if (BackingStoreCompositingSurface* surface = compositingSurface())


> Source/WebKit/blackberry/WebKitSupport/GLES2Context.cpp:91
> +    if (surface)

Ditto