[webkit-reviews] review requested: [Bug 32410] [Qt] Allow to use WebCore image decoders : [Attachment 128446] Allow to use WebCore image decoders

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has asked  for review:
Bug 32410: [Qt] Allow to use WebCore image decoders
https://bugs.webkit.org/show_bug.cgi?id=32410

Attachment 128446: Allow to use WebCore image decoders
https://bugs.webkit.org/attachment.cgi?id=128446&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
(In reply to comment #21)

> > Source/WebCore/WebCore.pri:212
> > +	     $$SOURCE_DIR/platform/image-decoders/webp
> 
> Doesn't webp require another library? (just curious, don't have the sources
here right now)

Yeap, you are right. You need installed libwebp on the system. So I put it into
macro guards.
 
> > Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:106
> > +void error_exit(j_common_ptr cinfo) NO_RETURN;
> 
> Why do we need this and the other ports don't? Do we enable a compiler
warning the others don't see? Is it because of -Werror? Please explain in the
ChangeLog :)

I modified the changelog! :)

> > Source/WebCore/platform/image-decoders/qt/ImageFrameQt.cpp:43
> > +		 fmt = QImage::Format_RGB32;
> 
> The indentation of this block looks broken :)

Fixed.