[webkit-reviews] review granted: [Bug 79348] [Qt] Add support for touch cancellation : [Attachment 128438] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 79348: [Qt] Add support for touch cancellation
https://bugs.webkit.org/show_bug.cgi?id=79348

Attachment 128438: Patch
https://bugs.webkit.org/attachment.cgi?id=128438&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128438&action=review


> Source/WebCore/platform/qt/PlatformTouchEventQt.cpp:58
> +	   switch (points.at(i).state()) {
> +	   case Qt::TouchPointReleased: state =
PlatformTouchPoint::TouchReleased; break;
> +	   case Qt::TouchPointMoved: state = PlatformTouchPoint::TouchMoved;
break;
> +	   case Qt::TouchPointPressed: state =
PlatformTouchPoint::TouchPressed; break;
> +	   case Qt::TouchPointStationary: state =
PlatformTouchPoint::TouchStationary; break;

I know this is nice, but it is really proper coding style?

> Source/WebCore/platform/qt/PlatformTouchEventQt.cpp:61
> +	   // Qt does not have a TouchCancelled point state, so if we receive a
touch cancel event,

per point you mean?