[webkit-reviews] review denied: [Bug 79335] [Qt] Build fix. QQuickItem does not have a setInputMethodHints(Qt::InputMethodHints hints) method. : [Attachment 128407] patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 79335: [Qt] Build fix. QQuickItem does not have a
setInputMethodHints(Qt::InputMethodHints hints) method.
https://bugs.webkit.org/show_bug.cgi?id=79335

Attachment 128407: patch
https://bugs.webkit.org/attachment.cgi?id=128407&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Well, but this isn't quite correct either, we still _do_ need to propagate the
input method hints to the input method. It's just that the mechanism has
changed slightly. FWIW, the Qt 5 version that we're developing against
currently still has this method (see webkit-qt mailing list of announcements of
version changes).

That said, QQuickItem::setInputMethodHints has always been a convenience
function for not having to re-implement the inputMethodQuery. Since we do that
anyway though, we can apply a fix that works with any Qt 5 version, by
responding to the Qt::ImHints input method query and returning the hints from
the editor state there.