[webkit-reviews] review denied: [Bug 79237] [EFL][DRT] Implement setValueForUser and setAutofilled : [Attachment 128208] proposed patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 79237: [EFL][DRT] Implement setValueForUser and setAutofilled
https://bugs.webkit.org/show_bug.cgi?id=79237

Attachment 128208: proposed patch
https://bugs.webkit.org/attachment.cgi?id=128208&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
Accessing JSValueRef smells wrong. When you notice you're doing it, it will
indicate something wrong.

IMHO, what you need is WebKit level API to access WebCore::Element and its
autofill methods.
For example, Mac port has DOMElement obj-c class and Chromium has WebElement as
a wrapper of WebCore::Element.
I think you need similar for EFL. Just making bot green doesn't help in this
case.

Please consult some expert in your team and discuss what is the good API for
EFL port.