[webkit-reviews] review granted: [Bug 79319] Cleanup RenderBlock::moveChildrenTo : [Attachment 128376] Simple cleanup, removed unneeded inline check, while -> for and use moveChildTo.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 79319: Cleanup RenderBlock::moveChildrenTo
https://bugs.webkit.org/show_bug.cgi?id=79319

Attachment 128376: Simple cleanup, removed unneeded inline check, while -> for
and use moveChildTo.
https://bugs.webkit.org/attachment.cgi?id=128376&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128376&action=review


I wonder if this will have a performance effect.

> Source/WebCore/rendering/RenderBlock.cpp:992
> +    for (RenderObject* child = startChild; child && child != endChild; ) {
> +	   // Save our next sibling as moveChildTo will clear it.
> +	   RenderObject* nextSibling = child->nextSibling();
> +	   moveChildTo(toBlock, child, beforeChild, fullRemoveInsert);
> +	   child = nextSibling;
>      }

Just to make sure... there are no mutation events (or other JavaScript) run by
moveChildTo such that we would need to hold a RefPtr for child?