[webkit-reviews] review granted: [Bug 79304] Make parsing color presentation attributes do less pointless work. : [Attachment 128337] Le Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 79304: Make parsing color presentation attributes do less pointless work.
https://bugs.webkit.org/show_bug.cgi?id=79304

Attachment 128337: Le Patch
https://bugs.webkit.org/attachment.cgi?id=128337&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=128337&action=review


> Source/WebCore/ChangeLog:10
> +
> +	   Let HTMLElement::addHTMLColorToStyle() construct the color CSSValue
directly
> +	   rather than passing a string that has to go through CSSParser.
> +

A word about performance?

> Source/WebCore/css/StylePropertySet.h:74
> +    // These expand shorthand properties into multiple properties.
> +    bool setProperty(int propertyID, const String& value, bool important =
false, CSSStyleSheet* contextStyleSheet = 0);
> +    void setProperty(int propertyID, PassRefPtr<CSSValue>, bool important =
false);
> +
> +    // These do not. FIXME: This is too messy, we can do better.
>      bool setProperty(int propertyID, int value, bool important = false,
CSSStyleSheet* contextStyleSheet = 0);
>      bool setProperty(int propertyID, double value,
CSSPrimitiveValue::UnitTypes, bool important = false, CSSStyleSheet*
contextStyleSheet = 0);
> -    bool setProperty(int propertyID, const String& value, bool important =
false, CSSStyleSheet* contextStyleSheet = 0);
>      void setProperty(const CSSProperty&, CSSProperty* slot = 0);

This really needs cleaning up. Oh well, you have the FIXME.