[webkit-reviews] review granted: [Bug 79303] [Supplemental] should support constants : [Attachment 128335] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 79303: [Supplemental] should support constants
https://bugs.webkit.org/show_bug.cgi?id=79303

Attachment 128335: Patch
https://bugs.webkit.org/attachment.cgi?id=128335&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128335&action=review


> Source/WebCore/bindings/scripts/CodeGenerator.pm:631
> +		   push(@checks, "COMPILE_ASSERT($value == " .
$constant->extendedAttributes->{"ImplementedBy"} . "::$name,
${interfaceName}Enum${name}IsWrongUseDoNotCheckConstants);\n");

Do we need to make sure the header is included in the CPP file?