[webkit-reviews] review granted: [Bug 79279] Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs : [Attachment 128315] Patch v1

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 79279: Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess
hangs
https://bugs.webkit.org/show_bug.cgi?id=79279

Attachment 128315: Patch v1
https://bugs.webkit.org/attachment.cgi?id=128315&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128315&action=review


> Source/WebKit2/UIProcess/WebLoaderClient.cpp:245
> +    if (m_client.version > 0 || !m_client.shouldGoToBackForwardListItem)
>	   return true;

You should add a comment here explaining the version check.

> Source/WebKit2/WebProcess/WebPage/WebPage.h:506
> +    bool willGoToBackForwardItemCallbackEnabled() { return
m_willGoToBackForwardItemCallbackEnabled; }

This can be const.