[webkit-reviews] review granted: [Bug 79027] Output a message on the console when using showModalDialog discouraging its use : [Attachment 127951] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 79027: Output a message on the console when using showModalDialog
discouraging its use
https://bugs.webkit.org/show_bug.cgi?id=79027

Attachment 127951: Patch
https://bugs.webkit.org/attachment.cgi?id=127951&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127951&action=review


> Source/WebCore/page/DOMWindow.cpp:1903
> +    DEFINE_STATIC_LOCAL(String, consoleMessage, ("window.showModalDialog is
broken and deprecated in WebKit. It will be removed from the engine in the
future."));

Apple isn't going to like commenting on future plans.  Perhaps "It will likely
be removed ..." ?