[webkit-reviews] review granted: [Bug 77493] PopStateEvent.state should use the same object as history.state : [Attachment 127283] Got rid of gotos

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 22 15:11:10 PST 2012


Adam Barth <abarth at webkit.org> has granted Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 77493: PopStateEvent.state should use the same object as history.state
https://bugs.webkit.org/show_bug.cgi?id=77493

Attachment 127283: Got rid of gotos
https://bugs.webkit.org/attachment.cgi?id=127283&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127283&action=review


> Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp:53
> +    v8::Handle<v8::String> propertyName = v8::String::NewSymbol("state");

Why not use V8HiddenPropertyNames ?


More information about the webkit-reviews mailing list