[webkit-reviews] review denied: [Bug 79143] [Texmap] Consolidate the common parts of TextureMapperGL::drawTexture : [Attachment 128288] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 22 14:46:42 PST 2012


Noam Rosenthal <noam.rosenthal at nokia.com> has denied Yael
<yael.aharon at nokia.com>'s request for review:
Bug 79143: [Texmap] Consolidate the common parts of
TextureMapperGL::drawTexture
https://bugs.webkit.org/show_bug.cgi?id=79143

Attachment 128288: Patch.
https://bugs.webkit.org/attachment.cgi?id=128288&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
This could work a lot better if we just call something like
TextureMapperShaderProgram::prepare that deals with the shader-specific
aspects, and then do the drawing in a common drawTexture function.


More information about the webkit-reviews mailing list