[webkit-reviews] review granted: [Bug 79271] Allocations from CopiedBlocks should always be 8-byte aligned : [Attachment 128282] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 79271: Allocations from CopiedBlocks should always be 8-byte aligned
https://bugs.webkit.org/show_bug.cgi?id=79271

Attachment 128282: Patch
https://bugs.webkit.org/attachment.cgi?id=128282&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128282&action=review


r=me

> Source/JavaScriptCore/wtf/StdLibExtras.h:120
> +    ASSERT(sizeof(unsigned long long) == 8);
> +    return !((unsigned long long)(p) & (sizeof(unsigned long long) - 1));

The best data type for the cast is uintptr_t.

There's no reason to use sizeof(unsigned long long). You should just use 7 and
8, which is what your function guarantees, or sizeof(JSValue), since that's
what you're worried about, or sizeof(double), which you should also be worried
about.