[webkit-reviews] review denied: [Bug 32410] [Qt] Allow to use WebCore image decoders : [Attachment 128165] Allow to compile WebCore imagedecoders

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 32410: [Qt] Allow to use WebCore image decoders
https://bugs.webkit.org/show_bug.cgi?id=32410

Attachment 128165: Allow to compile WebCore imagedecoders
https://bugs.webkit.org/attachment.cgi?id=128165&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128165&action=review


Looks good in general! I like the minimalistic approach. A few nitpicks below
:)

> Source/WebCore/WebCore.pri:212
> +	   $$SOURCE_DIR/platform/image-decoders/webp

Doesn't webp require another library? (just curious, don't have the sources
here right now)

> Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:106
> +void error_exit(j_common_ptr cinfo) NO_RETURN;

Why do we need this and the other ports don't? Do we enable a compiler warning
the others don't see? Is it because of -Werror? Please explain in the ChangeLog
:)

> Source/WebCore/platform/image-decoders/qt/ImageFrameQt.cpp:43
> +	       fmt = QImage::Format_RGB32;

The indentation of this block looks broken :)