[webkit-reviews] review granted: [Bug 79256] [BlackBerry] Fat fingers - Add a clearer way to distinguish the node we want (shadow or non-shadow) : [Attachment 128251] patch v1

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Antonio Gomes <tonikitoo at webkit.org>'s
request for review:
Bug 79256: [BlackBerry] Fat fingers - Add a clearer way to distinguish the node
we want (shadow or non-shadow)
https://bugs.webkit.org/show_bug.cgi?id=79256

Attachment 128251: patch v1
https://bugs.webkit.org/attachment.cgi?id=128251&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128251&action=review


Looks good with some stuff to fix before landing.

> Source/WebKit/blackberry/WebKitSupport/FatFingers.h:51
> +enum ContentType { ShadowContentAllowed, ShadowContentNotAllowed };

Better move it into FatFingersResult class before landing.

> Source/WebKit/blackberry/WebKitSupport/FatFingers.h:96
> +    }

Not sure if this makes sense inlined, might need measurements, not required for
landing this though.