[webkit-reviews] review granted: [Bug 77307] [chromium] Have WebFrameImpl::selectionAsMarkup create interchange markup. : [Attachment 128112] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Peter Collingbourne
<peter at pcc.me.uk>'s request for review:
Bug 77307: [chromium] Have WebFrameImpl::selectionAsMarkup create interchange
markup.
https://bugs.webkit.org/show_bug.cgi?id=77307

Attachment 128112: Patch
https://bugs.webkit.org/attachment.cgi?id=128112&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128112&action=review


> LayoutTests/platform/chromium/http/tests/misc/selectionAsMarkup.html:11
> +This test makes sure that the markup used by print selection
> +contains absolute urls and pushed down styles. This test depends
> +on layoutTestController.

Sorry, it occurs to me that this text will not be visible because of the
redirect.  I had meant for the text to be visible when loading the test in a
browser (maybe by moving this text to the html file we redirect to).