[webkit-reviews] review denied: [Bug 79245] Web Inspector: in start-at-zero mode of timeline panel, calculate window boundaries based on filtered events : [Attachment 128223] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 22 08:50:05 PST 2012


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 79245: Web Inspector: in start-at-zero mode of timeline panel, calculate
window boundaries based on filtered events
https://bugs.webkit.org/show_bug.cgi?id=79245

Attachment 128223: Patch
https://bugs.webkit.org/attachment.cgi?id=128223&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128223&action=review


> Source/WebCore/inspector/front-end/TimelinePanel.js:748
> +	   if (!this._boundariesAreValid && !this._startAtZero)

This looks like a hack, we should come up with a better filtering strategy.


More information about the webkit-reviews mailing list