[webkit-reviews] review denied: [Bug 79212] [BlackBerry] Upstream ImageBlackBerry in platform/graphics/blackberry : [Attachment 128163] patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Robin Cao
<robin.cao at torchmobile.com.cn>'s request for review:
Bug 79212: [BlackBerry] Upstream ImageBlackBerry in
platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=79212

Attachment 128163: patch
https://bugs.webkit.org/attachment.cgi?id=128163&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128163&action=review


Still some stuff to improve.

> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:2
> + * Copyright (C) 2010, 2011 Research In Motion Limited. All rights reserved.


Needs 2012.

> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:30
> +    String iconName(name); // a.k.a. "enable string comparisons with =="

I dont see a need for this, why not just use strcmp?

> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:40
> +	   context->fillRect(FloatRect(0, 0, 16, 16), Color::white,
ColorSpaceDeviceRGB);

There may be a variant that flood fills the entire surface, then you dont need
to specify the FloatRect.

> Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp:59
> +    // FIXME: Have a setting for the resource path

Is the FIXME still accurate?