[webkit-reviews] review denied: [Bug 79196] [BlackBerry] Upstream GLES2Context.{h, cpp} : [Attachment 128155] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 79196: [BlackBerry] Upstream GLES2Context.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79196

Attachment 128155: Patch
https://bugs.webkit.org/attachment.cgi?id=128155&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=128155&action=review


Still some things to improve.

> Source/WebKit/blackberry/WebKitSupport/GLES2Context.cpp:42
> +#include "WebPage_p.h"

All needed?

> Source/WebKit/blackberry/WebKitSupport/GLES2Context.cpp:44
> +#include <BlackBerryPlatformWindow.h>

Already included in header.

> Source/WebKit/blackberry/WebKitSupport/GLES2Context.cpp:113
> +    // Sniff, this is so sad.

Seems a strange comment, maybe explain why it is sad

> Source/WebKit/blackberry/WebKitSupport/GLES2Context.h:39
> +#include <wtf/OwnPtr.h>

Is this one needed?