[webkit-reviews] review granted: [Bug 79116] Web Inspector: do not filter out requestAnimationFrame from timeline, implement stop on animation events. : [Attachment 127979] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 22 04:05:00 PST 2012


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 79116: Web Inspector: do not filter out requestAnimationFrame from
timeline, implement stop on animation events.
https://bugs.webkit.org/show_bug.cgi?id=79116

Attachment 127979: Patch
https://bugs.webkit.org/attachment.cgi?id=127979&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127979&action=review


> Source/WebCore/dom/ScriptedAnimationController.cpp:88
> +    InspectorInstrumentation::didRequestAnimationFrameCallback(m_document,
id);

didRequestAnimationFrameCallback -> didRequestAnimationFrame ?

> Source/WebCore/inspector/InspectorInstrumentation.cpp:996
> +void
InspectorInstrumentation::didRequestAnimationFrameCallbackImpl(InstrumentingAge
nts* instrumentingAgents, int callbackId)

didRequestAnimationFrameCallbackImpl -> didRequestAnimationFrameImpl


More information about the webkit-reviews mailing list