[webkit-reviews] review requested: [Bug 32410] [Qt] Allow to use WebCore image decoders : [Attachment 128165] Allow to compile WebCore imagedecoders

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 22 02:46:39 PST 2012


Zoltan Horvath <zoltan at webkit.org> has asked  for review:
Bug 32410: [Qt] Allow to use WebCore image decoders
https://bugs.webkit.org/show_bug.cgi?id=32410

Attachment 128165: Allow to compile WebCore imagedecoders
https://bugs.webkit.org/attachment.cgi?id=128165&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
This patch adds ENABLE guards around QtImageDecoders only, but I set it to use
it by default, so there are no behavior change. If somebody wants to test
WebCore imgdecoders then just pass ENABLE_QT_IMAGE_DECODER=0 to the build.

The next step would be to put the fallback to QtImageDecoders into WebCore and
set WebCore ImageDecoders to default. In this case compiling of QtImageDecoders
will be disabled until we fix security issues.


More information about the webkit-reviews mailing list