[webkit-reviews] review denied: [Bug 78613] Paddings and borders on root SVG element with viewbox causes child SVG elements to be rendered with the incorrect size : [Attachment 128054] Patch for review.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 22 00:40:13 PST 2012


Nikolas Zimmermann <zimmermann at kde.org> has denied Max Vujovic
<mvujovic at adobe.com>'s request for review:
Bug 78613: Paddings and borders on root SVG element with viewbox causes child
SVG elements to be rendered with the incorrect size
https://bugs.webkit.org/show_bug.cgi?id=78613

Attachment 128054: Patch for review.
https://bugs.webkit.org/attachment.cgi?id=128054&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128054&action=review


Great catch, almost r+, still one issue:

> LayoutTests/platform/chromium/test_expectations.txt:933
> +BUGWK78613 : svg/custom/circle-move-invalidation-expected.svg = IMAGE
IMAGE+TEXT

Not sure how this works for reftest, but probably oyu need to mark
"circle-move-invaidation.svg" as failing, not the -expected.svg file.
cr-linux is still red, and I think this is the reason.


More information about the webkit-reviews mailing list