[webkit-reviews] review denied: [Bug 76816] Implement the URL decomposition IDL attributes : [Attachment 127144] Updated Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 76816: Implement the URL decomposition IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=76816

Attachment 127144: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=127144&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127144&action=review


> Source/WebCore/ChangeLog:7
> +

Please describe what your patch is doing.
Isn't there any spec to support this change?

> Source/WebCore/html/DOMURL.idl:33
> +	   Replaceable

[Replaceable] cannot be specified on an interface. What did you intend by
[Replaceable]? Please see the WebKit IDL document
(https://trac.webkit.org/wiki/WebKitIDL).

> Source/WebCore/html/DOMURL.idl:45
> +	   readonly attribute DOMString origin;

Maybe "readonly attribute [Reflect, URL] DOMString origin"? Please confirm the
spec and the WebKit IDL document.

> Source/WebCore/html/DOMURL.idl:46
> +	   stringifier attribute DOMString href;

stringifier is not implemented by any code generators. Maybe "attribute
[Reflect, URL] DOMString href"?

> Source/WebCore/html/DOMURL.idl:47
> +	   [DontEnum] DOMString toString();

[DontEnum] is renamed to [NotEnumerable]