[webkit-reviews] review granted: [Bug 78549] [Chromium] New CCOcclusionTracker class with tests : [Attachment 128120] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 21 23:05:14 PST 2012


James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 78549: [Chromium] New CCOcclusionTracker class with tests
https://bugs.webkit.org/show_bug.cgi?id=78549

Attachment 128120: Patch
https://bugs.webkit.org/attachment.cgi?id=128120&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128120&action=review


Works for me! R=me with one style nit, feel free to address it when you address
the other FIXME in that header.

> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.h:94
> +    WTF_MAKE_NONCOPYABLE(CCOcclusionTrackerBase);

style nit: normally we put this right below the class declaration and above the
first public:


More information about the webkit-reviews mailing list