[webkit-reviews] review granted: [Bug 79183] [chromium] Avoid culling work for fully-non-opaque tiles, and add tracing for draw culling : [Attachment 128109] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 79183: [chromium] Avoid culling work for fully-non-opaque tiles, and add
tracing for draw culling
https://bugs.webkit.org/show_bug.cgi?id=79183

Attachment 128109: Patch
https://bugs.webkit.org/attachment.cgi?id=128109&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128109&action=review


>> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:244
>> +	TRACE_EVENT("CCLayerTreeHostImpl::optimizeRenderPasses()", this, 0);
> 
> Maybe a good opportunity to also report the # of passes here too?

We haven't been putting the '()' in traces for functions before. There's no
really strong reason for or against this convention, but it's what we've been
using so I'd like to stay consistent.

I believe you can pass parameters efficiently now by using the TRACE_EVENT1()
macro instead of TRACE_EVENT.  See the comments in TraceEvent.h for details