[webkit-reviews] review denied: [Bug 77068] [chromium] Add WebCore::FlingAnimator class for Android native-feel scrolling : [Attachment 124057] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Tien-Ren Chen
<trchen at chromium.org>'s request for review:
Bug 77068: [chromium] Add WebCore::FlingAnimator class for Android native-feel
scrolling
https://bugs.webkit.org/show_bug.cgi?id=77068

Attachment 124057: Patch
https://bugs.webkit.org/attachment.cgi?id=124057&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124057&action=review


I think that attempting to call straight into Java from WebKit is a bad
approach (not to mention it won't compile on all of our configs).  Better would
be to provide WebKit API for the embedder to control the fling animation curves
and then call into that.

> Source/WebCore/platform/chromium/FlingAnimatorAndroid.cpp:29
> +#include "base/android/jni_android.h"

you can't #include files from base/ inside WebKit.  This won't even compile

> Source/WebCore/platform/chromium/FlingAnimatorAndroid.cpp:56
> +    JNIEnv* env = AttachCurrentThread();

calling into Java straight from WebKit?  Ick.  How do you plan to test this?