[webkit-reviews] review denied: [Bug 79179] webkitpy: committers_unittest fuzzy matching is really slow : [Attachment 128105] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 79179: webkitpy: committers_unittest fuzzy matching is really slow
https://bugs.webkit.org/show_bug.cgi?id=79179

Attachment 128105: Patch
https://bugs.webkit.org/attachment.cgi?id=128105&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128105&action=review


> Tools/Scripts/webkitpy/common/config/committers_unittest.py:117
> +	   contributors_used_in_tests = [all_committers.contributor_by_name(c)
for c in self._contributors if c]

I don't think this change is safe. A big part of this test is so that we don't
mismatch new contributors to alias of old contributors. e.g. darin shouldn't
match Darin Fisher.