[webkit-reviews] review denied: [Bug 78940] [chromium] Remove ASSERT. Mask texture not always available on composite thread. : [Attachment 127664] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 21 18:56:49 PST 2012
James Robinson <jamesr at chromium.org> has denied Eric Penner
<epenner at chromium.org>'s request for review:
Bug 78940: [chromium] Remove ASSERT. Mask texture not always available on
composite thread.
https://bugs.webkit.org/show_bug.cgi?id=78940
Attachment 127664: Patch
https://bugs.webkit.org/attachment.cgi?id=127664&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
We shouldn't push an invalid texture to the impl side. If we don't have the
texture, then we shouldn't push any tiles. How is it getting here without
setting skipsDraw()/etc?
If we don't have the mask then we should either skip the layer completely or
draw without trying to bind the mask. We shouldn't bind 0.
More information about the webkit-reviews
mailing list