[webkit-reviews] review requested: [Bug 79174] Early-out in Region::unite() for adding an empty region. : [Attachment 128099] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 21 18:06:27 PST 2012
Dana Jansens <danakj at chromium.org> has asked for review:
Bug 79174: Early-out in Region::unite() for adding an empty region.
https://bugs.webkit.org/show_bug.cgi?id=79174
Attachment 128099: Patch
https://bugs.webkit.org/attachment.cgi?id=128099&action=review
------- Additional Comments from Dana Jansens <danakj at chromium.org>
We've noticed that unite() with an empty region ends up making a copy of the
entire current Region, and may also add an empty rect in the return from
rects(). This early out saves a lot of work for this case, and fixes Region
uniqueness for the given area it covers.
More information about the webkit-reviews
mailing list