[webkit-reviews] review granted: [Bug 79170] Should be able to reconfigure a non-configurable property as writable : [Attachment 128095] Fix

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 79170: Should be able to reconfigure a non-configurable property as
writable
https://bugs.webkit.org/show_bug.cgi?id=79170

Attachment 128095: Fix
https://bugs.webkit.org/attachment.cgi?id=128095&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128095&action=review


> Source/JavaScriptCore/ChangeLog:3
> +	   Should be able to reconfigure a non-configurable property as
writable

This title contradicts the description below.

> Source/JavaScriptCore/runtime/JSGlobalData.h:252
> -
> +	   

Why?

> Source/JavaScriptCore/runtime/JSGlobalData.h:370
> +	   bool m_inDefineOwnProperty;
> +
> +

This whitespace is not all needed.