[webkit-reviews] review denied: [Bug 78721] Rename DOMWindow to Window in the bindings : [Attachment 128083] WIP

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 78721: Rename DOMWindow to Window in the bindings
https://bugs.webkit.org/show_bug.cgi?id=78721

Attachment 128083: WIP
https://bugs.webkit.org/attachment.cgi?id=128083&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128083&action=review


The approach looks good to me.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

Please add run-bindings-tests.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:-3782
> -sub GetVisibleInterfaceName

Maybe you can remove GetVisibleInterfaceName() from CodeGeneratorJS.pm too?

> Source/WebCore/bindings/scripts/IDLAttributes.txt:55
> +InterfaceName=*

Thanks for using IDLAttributes.txt, which was introduced today:-)