[webkit-reviews] review granted: [Bug 79162] ContainerNode::childrenChanged must be called immediately after removing children : [Attachment 128071] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 21 16:30:13 PST 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 79162: ContainerNode::childrenChanged must be called immediately after
removing children
https://bugs.webkit.org/show_bug.cgi?id=79162

Attachment 128071: Patch
https://bugs.webkit.org/attachment.cgi?id=128071&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128071&action=review


> LayoutTests/fast/dom/title-directionality-removeChild.html:21
> +    var dir = window.layoutTestController ?
> +	   layoutTestController.titleTextDirection
> +	 : 'layoutTestController unavailable';

Why is this statement split into 3 lines? It seems like it can fit in one line.


More information about the webkit-reviews mailing list