[webkit-reviews] review granted: [Bug 79148] nrwt: make the delay between starting workers configurable per-port : [Attachment 128041] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 21 16:18:55 PST 2012


Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 79148: nrwt: make the delay between starting workers configurable per-port
https://bugs.webkit.org/show_bug.cgi?id=79148

Attachment 128041: Patch
https://bugs.webkit.org/attachment.cgi?id=128041&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=128041&action=review


> Tools/Scripts/webkitpy/layout_tests/port/base.py:177
> +	   # FIXME: If we start workers up too quickly, DumpRenderTree appears
> +	   # to thrash on something and time out its first few tests. Until
> +	   # we can figure out what's going on, sleep a bit in between
> +	   # workers. See https://bugs.webkit.org/show_bug.cgi?id=79147 .
> +	   return 0.1

On which ports does this occur?  Can we do this only on some ports?


More information about the webkit-reviews mailing list