[webkit-reviews] review granted: [Bug 79050] MEDIA_STREAM should be implemented as a PageSupplement. : [Attachment 127899] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 21 15:54:51 PST 2012
Adam Barth <abarth at webkit.org> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 79050: MEDIA_STREAM should be implemented as a PageSupplement.
https://bugs.webkit.org/show_bug.cgi?id=79050
Attachment 127899: Patch
https://bugs.webkit.org/attachment.cgi?id=127899&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127899&action=review
> Source/WebCore/mediastream/UserMediaController.cpp:34
> + DEFINE_STATIC_LOCAL(AtomicString, name, ("userMedia"));
I would have called this UserMediaController to match the class name. (Just to
make sure there are no collisions.)
More information about the webkit-reviews
mailing list