[webkit-reviews] review granted: [Bug 78840] Abstract ImageEventSender into a general purpose EventSender : [Attachment 127464] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 78840: Abstract ImageEventSender into a general purpose EventSender
https://bugs.webkit.org/show_bug.cgi?id=78840

Attachment 127464: Patch
https://bugs.webkit.org/attachment.cgi?id=127464&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127464&action=review


> Source/WebCore/dom/EventSender.h:88
> +    if (m_dispatchSoonList.isEmpty())
> +	   m_timer.stop();

Do you mean to check whether the list is empty or whether it contains all
zeros?	I'm not sure how this function could result in m_dispatchSoonList being
empty if it wasn't already empty.

> Source/WebCore/loader/ImageLoader.cpp:-385
> -    if (m_dispatchSoonList.isEmpty())
> -	   m_timer.stop();

I see this was here already.  We might want to ask the original author why they
intended here.