[webkit-reviews] review granted: [Bug 78939] Remove the remaining uses of CSSStyleDeclaration in Editor : [Attachment 127663] Patch

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted  review:
Bug 78939: Remove the remaining uses of CSSStyleDeclaration in Editor
https://bugs.webkit.org/show_bug.cgi?id=78939

Attachment 127663: Patch
https://bugs.webkit.org/attachment.cgi?id=127663&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127663&action=review


Looks good to me. Great job, BTW :-). Please make sure you check the EWS before
landing. I saw you already fixed some build breakage.

> Source/WebCore/ChangeLog:22
> +	   (Editor):

The 2 lines above don't add any information.

> Source/WebCore/ChangeLog:35
> +	   (EditorClient):

Ditto.

> Source/WebKit/mac/WebView/WebFrame.mm:802
> +    // FIXME: We shouldn't have to create a copy here.

This comment should be as detailed as the one on line 4356 of WebHTMLView.mm.

> Source/WebKit/mac/WebView/WebHTMLView.mm:4658
> +	       // FIXME: We shouldn't have to make a copy here.

Same here.

> Source/WebKit/mac/WebView/WebView.mm:5528
> +    // FIXME: We shouldn't have to make a copy here.

Same here.