[webkit-reviews] review granted: [Bug 78926] Full Screen Refactor Part 2: Remove unnecessary WebKit2 APIs for Full Screen made : [Attachment 127850] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 21 11:25:20 PST 2012


John Sullivan <sullivan at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 78926: Full Screen Refactor Part 2: Remove unnecessary WebKit2 APIs for
Full Screen made
https://bugs.webkit.org/show_bug.cgi?id=78926

Attachment 127850: Patch
https://bugs.webkit.org/attachment.cgi?id=127850&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127850&action=review


> Source/WebKit2/UIProcess/WebFullScreenManagerProxy.h:85
> +    void disposeOfLayerClient() { } // FIXME: Remove

These “// FIXME: Remove” comments don’t provide enough context. Is there a bug
number about removing them that you could cite here? Otherwise, they need more
context about when they can/should be removed.


More information about the webkit-reviews mailing list