[webkit-reviews] review granted: [Bug 79126] ScrollingCoordinator::coordinatesScrollingForFrameView should be conditional on compositing being active : [Attachment 127995] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 21 10:57:15 PST 2012


Anders Carlsson <andersca at apple.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 79126: ScrollingCoordinator::coordinatesScrollingForFrameView should be
conditional on compositing being active
https://bugs.webkit.org/show_bug.cgi?id=79126

Attachment 127995: Patch
https://bugs.webkit.org/attachment.cgi?id=127995&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127995&action=review


> Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:-205
> +    setScrollLayer(scrollLayerForFrameView(frameView));
>      frameViewLayoutUpdated(frameView);
>      recomputeWheelEventHandlerCount();
>      updateShouldUpdateScrollLayerPositionOnMainThread();
> -    setScrollLayer(scrollLayerForFrameView(frameView));

This change isn't mentioned in the change log; why is it needed?


More information about the webkit-reviews mailing list