[webkit-reviews] review canceled: [Bug 79083] Unnecessary preprocessor macro in MainThread.h/cpp : [Attachment 127992] patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has canceled Roland Takacs
<Takacs.Roland at stud.u-szeged.hu>'s request for review:
Bug 79083: Unnecessary preprocessor macro in MainThread.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=79083

Attachment 127992: patch
https://bugs.webkit.org/attachment.cgi?id=127992&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
THX for the patch.

(In reply to comment #8)
> > > Source/JavaScriptCore/ChangeLog:10
> > > +        Futhermore the decoration name of isMainThreadOrGCThread
> > > +        was inserted to the JavaScriptCore.def.
> > 
> > Please explain why.
> 
> When I changed 'WINDOWS' to 'WIN' and I uploaded the patch, it failed.
Secondly, I added the isMainThreadOrGCThreads mangled name to the
JavaScriptCore.def, and it works.

The ChangeLog should usually explain the what and why. When browsing the
history you usually don't look into the bug, so any relevant information should
go into ChangeLog. :-)