[webkit-reviews] review denied: [Bug 78481] [GTK] DRT doesn't support scheduleAsynchronousKeyDown. : [Attachment 127978] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied ChangSeok Oh
<kevin.cs.oh at gmail.com>'s request for review:
Bug 78481: [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
https://bugs.webkit.org/show_bug.cgi?id=78481

Attachment 127978: Patch
https://bugs.webkit.org/attachment.cgi?id=127978&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127978&action=review


r-, although it's just for a few nitpicks and a possible useless include, I
think you'll prefer to upload a new patch anyway? =)

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:53
> +#include "PlatformKeyboardEvent.h"

Why do we need this extra include?

> Tools/DumpRenderTree/gtk/EventSender.cpp:761
> +	   sendKeyDown(static_cast<gpointer>(pressEvent));

I think I would prefer to have a proper function with the appropriate type for
the argument that is called from here and from the idle callback.