[webkit-reviews] review denied: [Bug 78985] Web Inspector: Audit rules to recommend unprefixing supported CSS properties : [Attachment 127949] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 78985: Web Inspector: Audit rules to recommend unprefixing supported CSS
properties
https://bugs.webkit.org/show_bug.cgi?id=78985

Attachment 127949: Patch
https://bugs.webkit.org/attachment.cgi?id=127949&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127949&action=review


> Source/WebCore/inspector/front-end/AuditRules.js:988
> +WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype = {

Although this implementation looks Ok, I think it would make sense to
generalize it. I.e. create a base CSS rule that would traverse through all the
CSSRules / CSSProperties and collect violations. That way it would be easier to
add new CSS rules.