[webkit-reviews] review denied: [Bug 78473] ShadowRoot needs innerHTML : [Attachment 127573] Patch with layout tests

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 78473: ShadowRoot needs innerHTML
https://bugs.webkit.org/show_bug.cgi?id=78473

Attachment 127573: Patch with layout tests
https://bugs.webkit.org/attachment.cgi?id=127573&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127573&action=review


> Source/WebCore/dom/ShadowRoot.cpp:156
> +	   replaceChildrenWithFragment(host(), fragment.release(), ec);

No, this is not what we need. we need to inject fragment to this ShadowRoot,
not the host.

> LayoutTests/fast/dom/shadow/shadow-root-innerHTML.html:24
> +shouldBeDefined("root.innerHTML");

This is not enough. We need to test
- the resulted string of innerHTML after setting innerHTML.
- the resulted DOM tree after setting innerHTML
- the innerHTML value for existing shadow DOM tree.