[webkit-reviews] review requested: [Bug 78936] [chromium] Refactor CCLayerTreeHostCommon: merge scattered setTargetRenderSurface logic : [Attachment 127917] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 20 22:13:22 PST 2012
Shawn Singh <shawnsingh at chromium.org> has asked for review:
Bug 78936: [chromium] Refactor CCLayerTreeHostCommon: merge scattered
setTargetRenderSurface logic
https://bugs.webkit.org/show_bug.cgi?id=78936
Attachment 127917: Patch
https://bugs.webkit.org/attachment.cgi?id=127917&action=review
------- Additional Comments from Shawn Singh <shawnsingh at chromium.org>
This patch pulls out the setTargetRenderSurface for the rootLayer special case.
However, it caused an explosion of places (in unit tests) where we have to
call setTargetRenderSurface. Because I will attempt to address the rootLayer
special case in the next refactoring patch, I would prefer to stick with the
previous patch on this bug. Vangelis, whatever you and other reviewers decide
is OK with me. I tested this patch on linux, no apparent regressions.
More information about the webkit-reviews
mailing list