[webkit-reviews] review denied: [Bug 78684] Layout issue with fieldset legend element : [Attachment 127791] New patch that updates previously failing pixel tests

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied SravanKumar S
<ssandela at innominds.com>'s request for review:
Bug 78684: Layout issue with fieldset legend element
https://bugs.webkit.org/show_bug.cgi?id=78684

Attachment 127791: New patch that updates previously failing pixel tests
https://bugs.webkit.org/attachment.cgi?id=127791&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127791&action=review


Thanks for taking this! 
The code basically looks OK. What's left is bureaucratic part...

1. It looks you don't set the mime type of the png files correctly. 
    Please check your svn configuration.
    http://trac.webkit.org/wiki/UsingGitWithWebKit

2. On chromium bot (cr-linux) redness, you can mark "fail" to these failing
test to make the bot OK.
    Someone from Chromium land will care about that then.
    http://trac.webkit.org/wiki/TestExpectations

> Source/WebCore/rendering/RenderFieldset.cpp:165
> +	   LayoutUnit clipWidth =
(max(static_cast<LayoutUnit>(style()->borderLeftWidth()), legend->width()));

Apparently this change isn't required.