[webkit-reviews] review denied: [Bug 78559] [EFL][DRT] Add initial implementation for TextInputController. : [Attachment 126877] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 20 21:28:26 PST 2012


MORITA Hajime <morrita at google.com> has denied Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 78559: [EFL][DRT] Add initial implementation for TextInputController.
https://bugs.webkit.org/show_bug.cgi?id=78559

Attachment 126877: Patch
https://bugs.webkit.org/attachment.cgi?id=126877&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=126877&action=review


> Tools/DumpRenderTree/efl/TextInputController.cpp:14
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of

I guess you don't need to claim anything about Apple ;-)

> Tools/DumpRenderTree/efl/TextInputController.cpp:40
> +static JSValueRef setMarkedTextCallback(JSContextRef context, JSObjectRef
function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef
arguments[], JSValueRef* exception)

Typically we don't give argument names which are not used in the function.
Some compiler actually complain about that.

> Tools/DumpRenderTree/efl/TextInputController.h:14
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of

Ditto for license.


More information about the webkit-reviews mailing list