[webkit-reviews] review denied: [Bug 77759] Missing include in TestNetscapePlugIn : [Attachment 125376] Explicitly include unistd.h in TestNetscapePlugIn

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 20 20:32:22 PST 2012


MORITA Hajime <morrita at google.com> has denied Kalev Lember
<kalevlember at gmail.com>'s request for review:
Bug 77759: Missing include in TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=77759

Attachment 125376: Explicitly include unistd.h in TestNetscapePlugIn
https://bugs.webkit.org/attachment.cgi?id=125376&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
We can just have both XP_UNIX and ANDROID. That would be intention revealing
and barely hurt the code.
I hope we had EWS for Android but currently we don't. Let us be conservative
until then.


More information about the webkit-reviews mailing list