[webkit-reviews] review denied: [Bug 78778] [Refactoring] Use HTMLInsertionPoint instead of HTMLContentElement : [Attachment 127796] use InsertionPoint
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 20 15:57:23 PST 2012
MORITA Hajime <morrita at google.com> has denied Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 78778: [Refactoring] Use HTMLInsertionPoint instead of HTMLContentElement
https://bugs.webkit.org/show_bug.cgi?id=78778
Attachment 127796: use InsertionPoint
https://bugs.webkit.org/attachment.cgi?id=127796&action=review
------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127796&action=review
> Source/WebCore/html/shadow/HTMLContentElement.h:NaN
> public:
It looks we no longer need some #include.
> Source/WebCore/html/shadow/InsertionPoint.cpp:43
> + , m_selections(adoptPtr(new HTMLContentSelectionList()))
If we instantiate here and have a #include, there would be no reason to
allocate this in heap.
I guess the original class lose the point at some point.
More information about the webkit-reviews
mailing list